rustpkg: Search for crates in the current directory #9736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current status: the test is failing on linux2, but if I ssh into rust-linux1 and run |
As per rust-lang#8520, find crates in the current working directory even if it's not a workspace. Closes rust-lang#8520
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 6, 2023
new lint: `iter_without_into_iter` Closes rust-lang#9736 A new lint that looks for `iter` (and `iter_mut`) method implementations without the type implementing `IntoIterator` for `&Type`. Imo this seems rather pedantic, so I went with that, but I can be convinced to change it to `style` like the linked issue asked for. Writing a machine applicable suggestion seems a bit tricky and tedious, so for now this relies on the user adding remaining lifetimes. changelog: new lint: `iter_without_into_iter`
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 6, 2023
new lint: `into_iter_without_iter` Closes rust-lang#9736 (part 2) This implements the other lint that my earlier PR missed: given an `IntoIterator for &Type` impl, check that there exists an inherent `fn iter(&self)` method. changelog: new lint: `into_iter_without_iter` r? `@Jarcho` since you reviewed rust-lang#11527 I figured it makes sense for you to review this as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @cmr As per #8520, find crates in the current working directory even
if it's not a workspace.
Closes #8520